[Mod_log_sql] mod_log_sql: how to send patch for NAT proxies

[Thomas Goirand]

On 12/06/2012 04:39 AM, Fawaad wrote:
> Dear Thomas,
> 
> I hope you don’t mind me emailing you direct, but I
> wanted to avoid any potential misunderstandings,
> regards recording remote_IPs in the database.

No pb.

> I was under the impression (from Google searches)
> that you were the official maintainer of the
> mod_log_sql.

I only wrote the score_board patch, which is available in
the Debian package of mod_log_sql, however, I am not the
author of the rest of it. This is maintained by upstream
author at:

http://www.outoforder.cc/projects/httpd/mod_log_sql/

The author is contactable through the mod_log_sql mailing
list, and he is usually quite responsive. I have added
the list to this email, so everyone knows about your intend
to patch mod_log_sql (I hope you don't mind me making your
email public).

If you would like to send patches against DTC, it's done
the same way: send a patch as an email attachment (see
below).

Note that the debian package I maintain isn't the very last
version of mod_log_sql, so you might want to use the latest
one from outoforder.cc.

> I appreciate your tight for time,
> hence I have downloaded and reviewed the mod_log_sql.c
> file from your site and it appears there's some clues
> to work in progress in the area of remote_ips and was
> noted to be outstanding within the code.

Where exactly did you read this? What file, and line?

> I think I can make out what needs to be done, but don’t
> know how to go about integrating any changes made to
> the .c file back for internal testing and then finally
> onto you as the maintainer.

Just produce a patch against the source, and send it to
both upstream author through the mailing list, and open
a bug against the libapache-mod-log-sql package in the
Debian bug tracking system. Then it will be processed,
hopefully.

> I have installed netbeans, Git, and downloaded DTC from
> your repo, but..
> How do you push out the repo tree to a working site to
> test - is it ok to just create folder mappings to the
> server ?
> If I made a patch, what would be the recommend
> requirements/procedure to get it integrated.

After a fresh clone of DTC, simply type:

make deb

and that will produce some debian packages for you to test.
Once you are done with your patch, you can do:

git commit -a

enter some comments in your $EDITOR, then save and quit.
Then use "git log" to find the last sha256 hash, and do:

git format-patch <sha256-hash-you-have-found-in-git-log>

then send over by email the git format-patch output.

Cheers,

Thomas