[Issues] [mod_auth_xradius 0000049]: dbm cache fails due to dbm_close while data still needed

[Mantis Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://issues.outoforder.cc/view.php?id=49 
====================================================================== 
Reported By:                richter
Assigned To:                
====================================================================== 
Project:                    mod_auth_xradius
Issue ID:                   49
Category:                   Other
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     new
Apache Version:             2.0.XX 
====================================================================== 
Date Submitted:             2005-12-30 09:05 EST
Last Modified:              2011-08-31 04:46 EDT
====================================================================== 
Summary:                    dbm cache fails due to dbm_close while data still
needed
Description: 
in function xrad_cachedbm_check a apr_dbm_close is called while the data in
dbmval is still needed, that causes sometimes a data corruption of the last char
of the password, causeing the cache to fail. This happens for me every 2 or 3
requests. After moveing the apr_dbm_close to the end of sub it works without
problems.

The attached patch fixes the problem
====================================================================== 

---------------------------------------------------------------------- 
 (0000285) kb (reporter) - 2011-08-31 04:26
 http://issues.outoforder.cc/view.php?id=49#c285 
---------------------------------------------------------------------- 
I had the same problem the cache failed sometimes due to data corruption on the
last character. I solved the problem by not including the final 0 character into
the stored key and value. Whatever the reason is for this behavior. 

---------------------------------------------------------------------- 
 (0000286) kb (reporter) - 2011-08-31 04:46
 http://issues.outoforder.cc/view.php?id=49#c286 
---------------------------------------------------------------------- 
OK, my first patch only reduced the failure rate to 1 out of 100 or so. Putting
that close at the end of the function finally fixes it (see  my second patch) 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2005-12-30 09:05 richter        New Issue                                    
2005-12-30 09:05 richter        File Added: dbm.patch                        
2005-12-30 09:05 richter        Apache Version            => 2.0.XX          
2011-08-31 04:23 kb             File Added: mod_auth_xradius-0.4.6-dbmkey.patch 
                  
2011-08-31 04:26 kb             Note Added: 0000285                          
2011-08-31 04:44 kb             File Added: mod_auth_xradius-0.4.6-dbmkey.patch2
                   
2011-08-31 04:46 kb             Note Added: 0000286                          
======================================================================