[Mod_log_sql] Fwd: Bug#666797: Building for apache 2.4

Thomas Goirand thomas at goirand.fr
Sat Apr 21 13:23:18 EDT 2012


On 04/21/2012 03:27 PM, Thomas Goirand wrote:
> Hi,
> 
> Here's the patch from Arno Töll, so that mod_log_sql can be built for
> Apache 2.4.
> 
> Thomas

Also, FYI, we could use this:

#if AP_MODULE_MAGIC_AT_LEAST(19980812,2)
	return r->useragent_ip;
#else
	return r->connection->remote_ip;
#endif

so that mod_log_sql would build on both old and new apache.

It'd be great to include this change upstream. Edward, do you think you
can release a new version of mod_log_sql with this change?

Also, I still carry my score_board patch in Debian, and it has never
been accepted. Do you feel that one day, it will? What should I add in
my patch to make it acceptable?

Cheers,

Thomas


More information about the Mod_log_sql mailing list